-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DataNode might OOM by estimating based on MemorySize #34203
Conversation
See also: milvus-io#34136 pr: milvus-io#34201 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn E2e jenkins job failed, comment |
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
rerun ut |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #34203 +/- ##
==========================================
- Coverage 81.82% 72.53% -9.30%
==========================================
Files 1010 1010
Lines 130787 130968 +181
==========================================
- Hits 107021 94999 -12022
- Misses 19766 31959 +12193
- Partials 4000 4010 +10
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See also: #34136
pr: #34201